| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tv(at)fuzzy(dot)cz>, Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Subject: | Re: hio.c does visibilitymap_pin()/IO while holding buffer lock |
| Date: | 2023-04-07 01:03:44 |
| Message-ID: | 20230407010344.2b2owzwqmtmdrjij@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-04-03 12:00:30 -0700, Andres Freund wrote:
> It's not great, I agree. I tried to make it easier to read in this version by
> a) changing GetVisibilityMapPins() as I proposed
> b) added a new variable "recheckVmPins", that gets set in
> if (unlockedTargetBuffer)
> and
> if (otherBuffer != InvalidBuffer)
> c) reformulated comments
I pushed this version a couple hours ago, after a bit more polishing.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-04-07 01:15:14 | Re: refactoring relation extension and BufferAlloc(), faster COPY |
| Previous Message | David Rowley | 2023-04-07 00:52:03 | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |