| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | melanieplageman(at)gmail(dot)com |
| Cc: | sawada(dot)mshk(at)gmail(dot)com, daniel(at)yesql(dot)se, pgsql-hackers(at)postgresql(dot)org, andres(at)anarazel(dot)de, amit(dot)kapila16(at)gmail(dot)com |
| Subject: | Re: Should vacuum process config file reload more often |
| Date: | 2023-03-29 04:21:55 |
| Message-ID: | 20230329.132155.629765142788133576.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 29 Mar 2023 12:09:08 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> timeing perfectly. I think we might accidentally add a reload
> timing. In that case, the assumption could break. In most cases, I
> think we use snapshotting in various ways to avoid unintended variable
> changes. (And I beilieve the analyze code also does that.)
Okay, I was missing the following code.
autovacuum.c:2893
/*
* If any of the cost delay parameters has been set individually for
* this table, disable the balancing algorithm.
*/
tab->at_dobalance =
!(avopts && (avopts->vacuum_cost_limit > 0 ||
avopts->vacuum_cost_delay > 0));
So, sorry for the noise. I'll review it while this into cnosideration.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-03-29 04:52:56 | RE: doc: add missing "id" attributes to extension packaging page |
| Previous Message | Amit Kapila | 2023-03-29 04:21:30 | Re: Data is copied twice when specifying both child and parent table in publication |