Re: pgsql: meson: add install-{quiet, world} targets

Hi,

On 2023-03-25 13:05:19 -0500, Justin Pryzby wrote:
> On Sat, Mar 25, 2023 at 11:03:10AM -0700, Andres Freund wrote:
> > Hi,
> >
> > On 2023-03-25 12:51:32 -0500, Justin Pryzby wrote:
> > > On Fri, Mar 24, 2023 at 04:30:52AM +0000, Andres Freund wrote:
> > > > meson: add install-{quiet, world} targets
> > >
> > > if docs.length() == 0
> > > run_target('docs', command: [missing, 'xsltproc'])
> > > else
> > > alias_target('docs', docs)
> > > + alias_target('install-docs', installdocs)
> > > endif
> > >
> > > This fails to handle installdocs.length() == 0
> >
> > You mean in the sense of causing a failure in meson, or not providing the
> > install-docs target? For the latter: Yea. I wasn't sure what the behaviour
>
> The former, I guess. I was going to look into the windows python header
> warnings, but the configure step failed like:
>
> [17:27:16.781] doc\src\sgml\meson.build:327:2: ERROR: alias_target takes at least 2 arguments, but got 1.

Huh - I thought that wouldn't be possible, because docs would also be empty in
that case. But it's not, because I added postgres-full.xml to docs (probably
so you can see docs xml validity issues with just xmllint available). So
"your" error happens if just xmllint, but not xsltproc is available.

I think the easiest "fix" might be to just define install-docs to also include
docs - that way install-docs at least checks the validity of xml, even if we
can't build any docs.

Greetings,

Andres Freund