Re: Doc: Improve note about copying into postgres_fdw foreign tables in batch

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: etsuro(dot)fujita(at)gmail(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, a(dot)lepikhov(at)postgrespro(dot)ru
Subject: Re: Doc: Improve note about copying into postgres_fdw foreign tables in batch
Date: 2023-03-22 12:08:53
Message-ID: 20230322.210853.803100407843635505.t-ishii@sranhm.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Fri, Feb 17, 2023 at 5:45 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>> Here is a small patch to improve the note, which was added by commit
>> 97da48246 ("Allow batch insertion during COPY into a foreign table."),
>> by adding an explanation about how the actual number of rows
>> postgres_fdw inserts at once is determined in the COPY case, including
>> a limitation that does not apply to the INSERT case.
>
> Does anyone want to comment on this?

> <para>
> - This option also applies when copying into foreign tables.
> + This option also applies when copying into foreign tables. In that case
> + the actual number of rows <filename>postgres_fdw</filename> copies at
> + once is determined in a similar way to in the insert case, but it is

"similar way to in" should be "similar way to", maybe?

> + limited to at most 1000 due to implementation restrictions of the
> + <command>COPY</command> command.
> </para>
> </listitem>
> </varlistentry>

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-03-22 12:13:01 Re: Doc: Improve note about copying into postgres_fdw foreign tables in batch
Previous Message Etsuro Fujita 2023-03-22 11:58:40 Re: Doc: Improve note about copying into postgres_fdw foreign tables in batch