| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pkg-config Requires.private entries should be comma-separated |
| Date: | 2023-03-15 16:10:14 |
| Message-ID: | 20230315161014.i35y23ygbakvagcp@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-03-15 08:51:04 +0100, Peter Eisentraut wrote:
> While comparing the .pc (pkg-config) files generated by the make and meson
> builds, I noticed that the Requires.private entries use different
> delimiters. The make build uses spaces, the meson build uses commas. The
> pkg-config documentation says that it should be comma-separated, but
> apparently about half the .pc in the wild use just spaces.
>
> The pkg-config source code acknowledges that both commas and spaces work:
>
> https://github.com/freedesktop/pkg-config/blob/master/parse.c#L273
> https://github.com/pkgconf/pkgconf/blob/master/libpkgconf/dependency.c#L286
>
> I think for consistency we should change the make build to use commas
> anyway. See attached patch.
Makes sense.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-03-15 16:23:19 | Re: optimize several list functions with SIMD intrinsics |
| Previous Message | Peter Eisentraut | 2023-03-15 15:57:34 | Re: CI and test improvements |