Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

From: "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com>
To: Greg Stark <stark(at)mit(dot)edu>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, "w^3" <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Date: 2023-03-14 21:29:19
Message-ID: 20230314162919.7342db4d@slate.karlpinc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On Tue, 14 Mar 2023 13:57:57 -0400
Greg Stark <stark(at)mit(dot)edu> wrote:

> Sorry, having read the whole thread I think it's clear. The source
> tree patch was committed by Alvaro H in
> a7e584a7d68a9a2bcc7efaf442262771f9044248 and then Katz pushed the
> pgweb change. So I gather this is resolved now and I've marked it
> committed by Alvaro.

There remains an un-committed patch from this thread/commitfest
entry:
v10-0002-Page-break-before-sect1-in-contrib-appendix-when-pdf.patch

When generating the PDF docs it starts each contrib entry on
a separate page.

From:
https://www.postgresql.org/message-id/20230122144246.0ff87372%40slate.karlpinc.com

I've re-attached the patch. Nobody has commented directly
on this particular patch, although there was a "looks ok" reply
to the email.

I don't know what the policy is now that the commitfest entry
is closed. Perhaps Alvaro was planning on committing it?

Please let me know if I should open up a new
commitfest entry or if there is something else I need to do.

Thanks for the help.

Regards,

Karl <kop(at)karlpinc(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

Attachment Content-Type Size
v10-0002-Page-break-before-sect1-in-contrib-appendix-when-pdf.patch text/x-patch 480 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2023-03-14 21:33:05 Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED
Previous Message Daniel Gustafsson 2023-03-14 20:24:32 Re: Making background psql nicer to use in tap tests

Browse pgsql-www by date

  From Date Subject
Next Message Alvaro Herrera 2023-03-15 08:41:27 Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Previous Message Greg Stark 2023-03-14 17:57:57 Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences