From: | 'Sandro Santilli' <strk(at)kbt(dot)io> |
---|---|
To: | Regina Obe <lr(at)pcorp(dot)us> |
Cc: | 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Gregory Stark (as CFM)'" <stark(dot)cfm(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, 'Regina Obe' <r(at)pcorp(dot)us> |
Subject: | Re: Ability to reference other extensions by schema in extension scripts |
Date: | 2023-03-13 11:59:16 |
Message-ID: | 20230313115916.ivvg4tj54szeu5rj@c19 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 11, 2023 at 03:18:18AM -0500, Regina Obe wrote:
> Attached is a revised patch with these changes in place.
I've given a try to this patch. It builds and regresses fine.
My own tests also worked fine. As long as ext1 was found
in the ext2's no_relocate list it could not be relocated,
and proper error message is given to user trying it.
Nitpicking, there are a few things that are weird to me:
1) I don't get any error/warning if I put an arbitrary
string into no_relocate (there's no check to verify the
no_relocate is a subset of the requires).
2) An extension can still reference extensions it depends on
without putting them in no_relocate. This may be intentional,
as some substitutions may not require blocking relocation, but
felt inconsistent with the normal @extschema@ which is never
replaced unless an extension is marked as non-relocatable.
--strk;
Libre GIS consultant/developer
https://strk.kbt.io/services.html
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Jones | 2023-03-13 12:08:11 | Re: [PATCH] Add pretty-printed XML output option |
Previous Message | Amit Kapila | 2023-03-13 11:48:13 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |