| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-superuser subscription owners |
| Date: | 2023-03-08 19:47:43 |
| Message-ID: | 20230308194743.23rmgjgwahh4i4rg@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-02-07 16:56:55 -0500, Robert Haas wrote:
> On Wed, Feb 1, 2023 at 4:02 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > + /* Is the use of a password mandatory? */
> > > + must_use_password = MySubscription->passwordrequired &&
> > > + !superuser_arg(MySubscription->owner);
> >
> > There's a few repetitions of this - perhaps worth putting into a helper?
>
> I don't think so. It's slightly different each time, because it's
> pulling data out of different data structures.
>
> > This still leaks the connection on error, no?
>
> I've attempted to fix this in v4, attached.
Hm - it still feels wrong that we error out in case of failure, despite the
comment to the function saying:
* Returns NULL on error and fills the err with palloc'ed error message.
Other than this, the change looks ready to me.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-03-08 20:11:14 | Re: Add error functions: erf() and erfc() |
| Previous Message | Robert Haas | 2023-03-08 19:40:42 | Re: postgres_fdw, dblink, and CREATE SUBSCRIPTION security |