From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
Subject: | meson vs make: missing/inconsistent ENV |
Date: | 2023-02-26 22:52:39 |
Message-ID: | 20230226225239.GL1653@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I noticed warnings:
Use of uninitialized value $ENV{"with_icu"} in string eq at /home/pryzbyj/src/postgres/src/bin/pg_dump/t/002_pg_dump.pl line 56.
and looked through: git grep ^export '*/Makefile'
and found that:
src/bin/pg_dump/meson.build is missing with_icu since 396d348b0
Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
it's not in ./Makefile ?? Maybe that was for consistency with other
places, or pre-emptive in case the tap tests want to do tests involving
the ZSTD tool. But it'd be better if ./Makefile had it too.
The rest I think are not errors:
src/test/meson.build is missing PG_TEST_EXTRA
src/bin/pg_upgrade/meson.build and ../src/test/recovery/meson.build
are missing REGRESS_SHLIB
Is there any consideration of promoting these or other warnings to
fatal?
--
Justin
From | Date | Subject | |
---|---|---|---|
Next Message | Takamichi Osumi (Fujitsu) | 2023-02-26 22:58:26 | RE: Allow logical replication to copy tables in binary format |
Previous Message | Melanie Plageman | 2023-02-26 21:24:40 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |