Re: BUG #17800: ON CONFLICT DO UPDATE fails to detect incompatible fields that leads to a server crash

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17800: ON CONFLICT DO UPDATE fails to detect incompatible fields that leads to a server crash
Date: 2023-02-24 23:57:04
Message-ID: 20230224235704.jz5ayb37x6miml6v@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi,

On 2023-02-24 18:49:10 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2023-02-24 17:12:43 -0500, Tom Lane wrote:
> >> I did the renaming you had comments suggesting, but perhaps you want
> >> to bikeshed those names?
>
> > Not really. I guess it'd be mildly nicer to have Expr somewhere in the name,
> > but whatever.
>
> Maybe Exec{Create|Push}ExprSetupSteps?

WFM.

> > The "don't bother" comment looks a bit lonely now :)
>
> I figured it was important to leave a note that that was intentional.
> Doesn't have to look exactly like that, though.

I'd just move it to the the loop evaluating the non resjunk columns.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message zhxpgh 2023-02-25 01:43:22 two bugs
Previous Message Tom Lane 2023-02-24 23:49:10 Re: BUG #17800: ON CONFLICT DO UPDATE fails to detect incompatible fields that leads to a server crash