| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | gkokolatos(at)pm(dot)me, shiy(dot)fnst(at)fujitsu(dot)com, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
| Subject: | Re: Add LZ4 compression in pg_dump |
| Date: | 2023-02-19 19:43:45 |
| Message-ID: | 20230219194345.GJ1653@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Some little updates since I last checked:
+ * This file also includes the implementation when compression is none for
+ * both API's.
=> this comment is obsolete.
s/deffer/infer/ ?
or determine ?
This typo occurs multiple times.
currently this includes only ".gz"
=> remove this phase from the 002 patch (or at least update it in 003).
deferred by iteratively
=> inferred?
s/Requrires/Requires/
twice.
s/occured/occurred/
s/disc/disk/ ?
Probably unimportant, but "disc" isn't used anywhere else.
"compress file handle"
=> maybe these should say "compressed"
supports_compression():
Since this is an exported function, it should probably be called
pgdump_supports_compresion.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2023-02-19 19:54:11 | Re: Missing free_var() at end of accum_sum_final()? |
| Previous Message | Tom Lane | 2023-02-19 19:01:13 | Re: wrong query result due to wang plan |