| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: recovery modules |
| Date: | 2023-02-08 16:27:13 |
| Message-ID: | 20230208162713.zavyhxywheh4kuns@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-02-08 16:23:34 +0900, Michael Paquier wrote:
> On Sat, Feb 04, 2023 at 10:14:36AM -0800, Nathan Bossart wrote:
> > On Sat, Feb 04, 2023 at 11:59:20AM +0900, Michael Paquier wrote:
> >> + ArchiveModuleCallbacks struct filled with the callback function pointers for
> >> This needs a structname markup.
> >>
> >> + can use <literal>state->private_data</literal> to store it.
> >> And here it would be structfield.
> >
> > fixed
>
> Andres, did you have the change to look at that? I did look at it,
> but it may not address all the points you may have in mind.
Yes, I think this looks pretty good now.
One minor thing: I don't think we really need the AssertVariableIsOfType() for
anything but the Init() one?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-02-08 16:58:59 | Re: Named Operators |
| Previous Message | Andres Freund | 2023-02-08 16:23:10 | Re: meson: Non-feature feature options |