| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Jelte Fennema <postgres(at)jeltef(dot)nl>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-02-04 04:18:48 |
| Message-ID: | 20230204041848.GC1896331@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 03, 2023 at 12:52:50PM -0500, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > On 2023-01-22 Su 17:47, Tom Lane wrote:
> >> Yeah. That's one of my biggest gripes about pgperltidy: if you insert
> >> another assignment in a series of assignments, it is very likely to
> >> reformat all the adjacent assignments because it thinks it's cool to
> >> make all the equal signs line up. That's just awful.
>
> > Modern versions of perltidy give you much more control over this, so
> > maybe we need to investigate the possibility of updating.
>
> I have no objection to updating perltidy from time to time. I think the
> idea is just to make sure that we have an agreed-on version for everyone
> to use.
Agreed. If we're changing the indentation of assignments, that's a
considerable diff already. It would be a good time to absorb other diffs
we'll want eventually, including diffs from a perltidy version upgrade.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takamichi Osumi (Fujitsu) | 2023-02-04 06:04:39 | RE: Time delayed LR (WAS Re: logical replication restrictions) |
| Previous Message | Michael Paquier | 2023-02-04 03:32:15 | Re: Add progress reporting to pg_verifybackup |