| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | melanieplageman(at)gmail(dot)com |
| Cc: | vignesh21(at)gmail(dot)com, andres(at)anarazel(dot)de, pryzby(at)telsasoft(dot)com, lukas(at)fittl(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, magnus(at)hagander(dot)net, pgsql-hackers(at)postgresql(dot)org, thomas(dot)munro(at)gmail(dot)com, m(dot)sakrejda(at)gmail(dot)com |
| Subject: | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |
| Date: | 2023-01-24 08:25:38 |
| Message-ID: | 20230124.172538.809130207355878809.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Tue, 24 Jan 2023 17:22:03 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> +pgstat_count_io_op(IOObject io_object, IOContext io_context, IOOp io_op)
> +{
> + Assert(io_object < IOOBJECT_NUM_TYPES);
> + Assert(io_context < IOCONTEXT_NUM_TYPES);
> + Assert(io_op < IOOP_NUM_TYPES);
> + Assert(pgstat_tracks_io_op(MyBackendType, io_object, io_context, io_op));
>
> Is there any reason for not checking the value ranges at the
> bottom-most functions? They can lead to out-of-bounds access so I
To make sure, the "They" means "out-of-range io_object/context/op
values"..
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-01-24 08:33:42 | Re: Time delayed LR (WAS Re: logical replication restrictions) |
| Previous Message | Kyotaro Horiguchi | 2023-01-24 08:22:03 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |