Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable.
Date: 2023-01-18 20:14:51
Message-ID: 20230118201451.f2dooawchsfy57qc@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2023-01-18 15:08:38 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2023-01-18 18:24:45 +0000, Tom Lane wrote:
> >> Get rid of the "new" and "old" entries in a view's rangetable.
>
> > This seems to have caused a test failure on windows. Looks like it's not
> > indicating a real problem, just that collate.windows.win1252.out needs to be
> > adapted.
>
> Huh, I wonder why the cfbot never complained about that when
> it was testing this patch ... maybe it doesn't use win1252?

This is the same environment that cfbot is also using, so this is odd. And
cfbot has been failing on windows since the commit went into master:

https://cirrus-ci.com/github/postgresql-cfbot/postgresql/

So I guess something must have changed in the patch since then? I guess it
could be that something changed on the VM, but I don't think so...

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-01-18 20:22:30 pgsql: Use dlists instead of SHM_QUEUE for syncrep queue
Previous Message Tom Lane 2023-01-18 20:08:38 Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable.