| From: | "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Devrim Gündüz <devrim(at)gunduz(dot)org>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: drop postmaster symlink |
| Date: | 2023-01-08 04:29:35 |
| Message-ID: | 20230107222935.5b63fad5@slate.karlpinc.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 7 Jan 2023 19:56:08 -0600
"Karl O. Pinc" <kop(at)karlpinc(dot)com> wrote:
> On Sat, 07 Jan 2023 18:38:25 -0500
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > "Karl O. Pinc" <kop(at)karlpinc(dot)com> writes:
> > > This is a review of Peter's 2 patches. I see only 1 small
> > > problem. ...
> > Hmm ... I thought this patch was about getting rid of the
> > admittedly-obsolete installed symlink. ...
> No. It's about getting rid of the symlink.
The only way I could think of to review a patch
that removes something is to report all the places
I looked where a reference to the symlink might be.
Then report what I found each place I looked and
report if there's a problem, or might be.
That way the committer knows where I didn't look if there's
more that needs removing.
Apologies that this was not clear.
Regards,
Karl <kop(at)karlpinc(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anton A. Melnikov | 2023-01-08 06:02:33 | Re: [BUG] Logical replica crash if there was an error in a function. |
| Previous Message | houzj.fnst@fujitsu.com | 2023-01-08 03:58:50 | RE: Perform streaming logical transactions by background workers and parallel apply |