Re: [PATCH] Porting small OpenBSD changes.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David CARLIER <devnexen(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Porting small OpenBSD changes.
Date: 2017-11-20 18:49:58
Message-ID: 20228.1511203798@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David CARLIER <devnexen(at)gmail(dot)com> writes:
> - Reducing OpenBSD postfgresql maintainer internal changes bookeeping if
> those small changes make sense for the PostgreSQL developers.

Hm. The s_lock.c change is surely fine if OpenBSD maintainers say it is.

Not sure about adding Motorola 88K support to s_lock.h ... is anybody
really still interested in that platform? OTOH, we still have M68K
and VAX stanzas in that file, so I suppose it's silly to complain
about 88K. A bigger issue is that I wonder whether that code has
ever been tested: it does not look to me like the __asm__ call is
even syntactically correct. There should be colons in it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David CARLIER 2017-11-20 18:57:47 Re: [PATCH] Porting small OpenBSD changes.
Previous Message Tom Lane 2017-11-20 18:40:57 Re: [HACKERS] pgbench regression test failure