| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, David Rowley <dgrowleyml(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Subject: | Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local |
| Date: | 2022-12-29 00:02:23 |
| Message-ID: | 20221229000223.2pdwxexfrgoximul@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-12-28 13:43:27 -0500, Tom Lane wrote:
> > In the compiler test, I chose to not check whether -Werror=unknown-pragmas is
> > supported - it appears to be an old gcc flag, and the worst outcome is that
> > HAVE_PRAGMA_SYSTEM_HEADER isn't defined.
> > We could alternatively define HAVE_PRAGMA_SYSTEM_HEADER or such based on
> > __GNUC__ being defined.
>
> Hmm ... I guess the buildfarm would tell us whether that detection works
> correctly on platforms where it matters. Let's keep it simple if we
> can.
Quick clarification question: Are you suggesting to use #ifdef __GNUC__, or
that it suffices to use -Werror=unknown-pragmas without a separate configure
check?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Will Mortensen | 2022-12-29 00:02:58 | [PATCH] two minor fixes to MVCC docs |
| Previous Message | Andres Freund | 2022-12-28 23:56:13 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |