Re: Using WaitEventSet in the postmaster

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Using WaitEventSet in the postmaster
Date: 2022-12-07 01:22:24
Message-ID: 20221207012224.hjcyzvwdjim22e2a@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-12-07 14:12:37 +1300, Thomas Munro wrote:
> On Wed, Dec 7, 2022 at 12:12 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On 2022-12-07 00:58:06 +1300, Thomas Munro wrote:
> > > One way to fix that for the epoll version is to EPOLL_CTL_DEL and
> > > EPOLL_CTL_ADD, whenever transitioning to/from a zero event mask.
> > > Tried like that in this version. Another approach would be to
> > > (finally) write DeleteWaitEvent() to do the same thing at a higher
> > > level... seems overkill for this.
> >
> > What about just recreating the WES during crash restart?
>
> It seems a bit like cheating but yeah that's a super simple solution,
> and removes one patch from the stack. Done like that in this version.

I somewhat wish we'd do that more aggressively during crash-restart, rather
than the opposite. Mostly around shared memory contents though, so perhaps
that's not that comparable...

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2022-12-07 01:36:05 Re: [DOCS] Stats views and functions not in order?
Previous Message Peter Smith 2022-12-07 01:14:01 Re: Force streaming every change in logical decoding