| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Generate pg_stat_get_* functions with Macros |
| Date: | 2022-12-04 17:32:07 |
| Message-ID: | 20221204173207.GA2669116@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 04, 2022 at 06:07:37AM +0100, Drouvot, Bertrand wrote:
> On 12/3/22 9:16 PM, Nathan Bossart wrote:
>> Thanks. I editorialized a bit in the attached v3. I'm not sure that my
>> proposed names for the macros are actually an improvement. WDYT?
>
> Thanks! I do prefer the macros definition ordering that you're proposing (that makes pgstatfuncs.c "easier" to read).
>
> As far the names, I think it's better to replace "TAB" with "REL" (like in v4 attached): the reason is that those macros will be used in [1] for both tables and indexes stats (and so we'd have to replace "TAB" with "REL" in [1]).
> Having "REL" already in place reduces the changes that will be needed in [1].
Alright. I marked this as ready-for-committer.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-12-04 19:09:35 | Re: CREATE INDEX CONCURRENTLY on partitioned index |
| Previous Message | Ankit Kumar Pandey | 2022-12-04 17:09:05 | Re: Questions regarding distinct operation implementation |