From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Reid Thompson <reid(dot)thompson(at)crunchydata(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
Subject: | Re: Add tracking of backend memory allocated to pg_stat_activity |
Date: | 2022-11-27 15:40:53 |
Message-ID: | 20221127154053.GS11463@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Nov 27, 2022 at 12:32:19AM -0500, Reid Thompson wrote:
> @@ -32,6 +33,12 @@ typedef enum BackendState
> STATE_DISABLED
> } BackendState;
>
> +/* Enum helper for reporting memory allocated bytes */
> +enum allocation_direction
> +{
> + DECREASE = -1,
> + INCREASE = 1,
> +};
BTW, these should have some kind of prefix, like PG_ALLOC_* to avoid
causing the same kind of problem for someone else that another header
caused for you by defining something somewhere called IGNORE (ignore
what, I don't know). The other problem was probably due to a define,
though. Maybe instead of an enum, the function should take a boolean.
I still wonder whether there needs to be a separate CF entry for the
0001 patch. One issue is that there's two different lists of people
involved in the threads.
--
Justin
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2022-11-27 16:02:18 | Re: pglz compression performance, take two |
Previous Message | Ted Yu | 2022-11-27 15:17:34 | Re: Add tracking of backend memory allocated to pg_stat_activity |