Re: Proposal: Allow user with pg_monitor role to call pg_stat_reset* functions

On Mon, Nov 21, 2022 at 03:47:38PM -0500, Robert Haas wrote:
> On Mon, Nov 21, 2022 at 3:45 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On 2022-11-21 00:16:20 -0800, sirisha chamarthi wrote:
> > > At present, calling pg_stat_reset* functions requires super user access
> > > unless explicitly grant execute permission on those. In this thread, I am
> > > proposing to grant execute on them to users with pg_monitor role
> > > permissions. This comes handy to the monitoring users (part of pg_monitor
> > > role) to capture the stats fresh and analyze. Do you see any concerns with
> > > this approach?
> >
> > I think the common assumption is that a monitoring role cannot modify
> > the system, but this would change that. Normally a monitoring tool
> > should be able to figure out what changed in stats by comparing values
> > across time, rather than resetting stats.
>
> +1.

This can have negative impact for autovacuum, so +1 too.