Re: Catalog_xmin is not advanced when a logical slot is lost

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: sirisha chamarthi <sirichamarthi22(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Subject: Re: Catalog_xmin is not advanced when a logical slot is lost
Date: 2022-11-21 09:18:58
Message-ID: 20221121091858.3jrbldpdubtjj3a4@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Nov-20, sirisha chamarthi wrote:

> Hi Hackers,
>
> forking this thread from the discussion [1] as suggested by Amit.
>
> Catalog_xmin is not advanced when a logical slot is invalidated (lost)
> until the invalidated slot is dropped. This patch ignores invalidated slots
> while computing the oldest xmin. Attached a small patch to address this and
> the output after the patch is as shown below.

Oh wow, that's bad :-( I'll get it patched immediately.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Here's a general engineering tip: if the non-fun part is too complex for you
to figure out, that might indicate the fun part is too ambitious." (John Naylor)
https://postgr.es/m/CAFBsxsG4OWHBbSDM%3DsSeXrQGOtkPiOEOuME4yD7Ce41NtaAD9g%40mail.gmail.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2022-11-21 09:21:09 Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)
Previous Message Masahiko Sawada 2022-11-21 08:42:34 Re: [PoC] Improve dead tuple storage for lazy vacuum