Re: [PoC] configurable out of disk space elog level

From: Andres Freund <andres(at)anarazel(dot)de>
To: Maxim Orlov <orlovmg(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PoC] configurable out of disk space elog level
Date: 2022-11-17 15:45:20
Message-ID: 20221117154520.62i6jbswln2urfjb@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-11-17 14:40:02 +0300, Maxim Orlov wrote:
> On Wed, 16 Nov 2022 at 20:41, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > that aside, we can't do catalog accesses in all kinds of environments that
> > this currently is active in - most importantly it's affecting the startup
> > process. We don't do catalog accesses in the startup process, and even if
> > we
> > were to do so, we couldn't unconditionally because the catalog might not
> > even
> > be consistent at this point (nor is it guaranteed that the wal_level even
> > allows to access catalogs during recovery).
> >
> Yep, that is why I do use in get_tablespace_elevel:
> + /*
> + * Use GUC level only in normal mode.
> + */
> + if (!IsNormalProcessingMode())
> + return ERROR;
>
> Anyway, I appreciate the opinion, thank you!

The startup process is in normal processing mode.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-11-17 15:48:52 Re: allow segment size to be set to < 1GiB
Previous Message Andres Freund 2022-11-17 15:39:10 Re: allow segment size to be set to < 1GiB