| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: Allow file inclusion in pg_hba and pg_ident files |
| Date: | 2022-11-12 08:13:53 |
| Message-ID: | 20221112081353.tyjdyu2fvcecdavw@jrouhaud |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 10, 2022 at 10:29:40AM +0900, Michael Paquier wrote:
>
> FWIW, I have been playing with the addition of a ErrorContextCallback
> in tokenize_auth_file(), and this addition leads to a really nice
> result. With this method, it is possible to know the full chain of
> events leading to a failure when tokenizing included files, which is
> not available now in the logs when reloading the server.
>
> We could extend it to have more verbose information by passing more
> arguments to tokenize_auth_file(), still I'd like to think that just
> knowing the line number and the full path to the file is more than
> enough once you know the full chain of events. 0001 and 0002 ought to
> be merged together, but I am keeping these separate to show how simple
> the addition of the ErrorContextCallback is.
It's looks good to me. I agree that file name and line number should be enough
to diagnose any unexpected error.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-11-12 11:05:46 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Aleksander Alekseev | 2022-11-12 06:57:06 | Re: [PoC] Let libpq reject unexpected authentication requests |