Re: allow segment size to be set to < 1GiB

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: allow segment size to be set to < 1GiB
Date: 2022-11-09 20:25:09
Message-ID: 20221109202509.nzsecnlfz5b42ooe@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-11-09 14:44:42 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > A second question: Both autoconf and meson print the segment size as GB right
> > now. Obviously that'll print out a size of 0 for a segsize < 1GB.
>
> > The easiest way to would be to just display the number of blocks, but that's
> > not particularly nice.
>
> Well, it would be fine if you'd written --with-segsize-blocks, wouldn't
> it? Can we make the printout format depend on which switch was used?

Not sure why I didn't think of that...

Updated patch attached.

I made one autoconf and one meson CI task use a small block size, but just to
ensure it work on both. I'd probably leave it set on one, so we keep the
coverage for cfbot?

Greetings,

Andres Freund

Attachment Content-Type Size
v2-0001-Add-option-to-specify-segment-size-in-blocks.patch text/x-diff 10.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Christensen 2022-11-09 20:37:29 Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Previous Message David Christensen 2022-11-09 20:08:11 Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL