| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: Allow file inclusion in pg_hba and pg_ident files |
| Date: | 2022-10-26 03:19:48 |
| Message-ID: | 20221026031948.cbrnzgy5e7glsq2d@jrouhaud |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 25, 2022 at 08:59:57PM +0900, Michael Paquier wrote:
>
> Hmm. I would be tempted to keep track of the file name and the line
> number as well in IdentLine. One reason is that this can become
> useful for debugging. A second is that this can reduce a bit the
> arguments of fill_ident_line() and fill_hba_line() in hbafuncs.c once
> we track these in HbaLine and IdentLine.
Ok, I guess something like the attached v14 is what you want.
> And HEAD is slightly
> overdoing it in its interface for the line number, actually, as we
> pass the line number twice: from {Ident,Hba}Line and the respective
> field from TokenizedAuthLine.
That wouldn't be overdoing anymore if we remove the line number / filename from
the fill_*_line prototypes right?
| Attachment | Content-Type | Size |
|---|---|---|
| v14-0001-Refactor-knowledge-of-origin-file-in-hba.c.patch | text/plain | 24.8 KB |
| v14-0002-Simplify-fill_hba_line-and-fill_ident_line-proto.patch | text/plain | 3.8 KB |
| v14-0003-Add-rule_number-mapping_number-to-the-pg_hba-pg_.patch | text/plain | 10.3 KB |
| v14-0004-Allow-file-inclusion-in-pg_hba-and-pg_ident-file.patch | text/plain | 68.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-10-26 04:12:50 | Re: Simplify standby state machine a bit in WaitForWALToBecomeAvailable() |
| Previous Message | Melanie Plageman | 2022-10-26 03:15:06 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |