| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Thomas Munro <tmunro(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows. |
| Date: | 2022-10-25 21:30:55 |
| Message-ID: | 20221025213055.GA8537@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, Oct 25, 2022 at 04:21:02PM -0500, Justin Pryzby wrote:
> > Restore that behavior with an explicit check, to see if it fixes the
> > occasional 'directory not empty' failures seen in the pg_upgrade tests
> > on CI. Further improvements are possible with proposed upgrades to
> > modern Windows APIs that would replace this convoluted code.
> >
> > Reported-by: Justin Pryzby <pryzby(at)telsasoft(dot)com>
> > Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
> > Discussion: https://postgr.es/m/20220920013122.GA31833%40telsasoft.com
> > Discussion: https://postgr.es/m/CA%2BhUKG%2BajSQ_8eu2AogTncOnZ5me2D-Cn66iN_-wZnRjLN%2Bicg%40mail.gmail.com
> ...
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/e109e43921d21d069c03f18d7c9d8f4e5cb6a0c3
>
> If I'm not wrong, this didn't fix the issue you said it fixed.
s/said/hoped/sorry
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-10-25 21:36:14 | pgsql: Doc/improve confusing, inefficient tests to locate CTID variable |
| Previous Message | Justin Pryzby | 2022-10-25 21:21:02 | Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows. |