From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Crash after a call to pg_backup_start() |
Date: | 2022-10-21 07:10:38 |
Message-ID: | 20221021.161038.1277961198945653224.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
While playing with a proposed patch, I noticed that a session crashes
after a failed call to pg_backup_start().
postgres=# select pg_backup_start(repeat('x', 1026));
ERROR: backup label too long (max 1024 bytes)
postgres=# \q
> TRAP: failed Assert("during_backup_start ^ (sessionBackupState == SESSION_BACKUP_RUNNING)"), File: "xlog.c", Line: 8846, PID: 165835
Surprisingly this happens by a series of succussful calls to
pg_backup_start and stop.
postgres=# select pg_backup_start('x');
postgres=# select pg_backup_top();
postgres=# \q
> TRAP: failed Assert("durin..
>> do_pg_abort_backup(int code, Datum arg)
> /* Only one of these conditions can be true */
> Assert(during_backup_start ^
> (sessionBackupState == SESSION_BACKUP_RUNNING));
It seems to me that the comment is true and the condition is a thinko.
This is introduced by df3737a651 so it is master only.
Please find the attached fix.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
fix_crash_after_backup_start.patch | text/x-patch | 614 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2022-10-21 07:45:59 | Re: Standby recovers records from wrong timeline |
Previous Message | Kyotaro Horiguchi | 2022-10-21 06:41:02 | Re: Avoid memory leaks during base backups |