| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: GUC values - recommended way to declare the C variables? |
| Date: | 2022-10-20 04:15:59 |
| Message-ID: | 20221020041559.GJ16921@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 20, 2022 at 11:56:58AM +1100, Peter Smith wrote:
> Patch 0002 adds a sanity-check function called by
> InitializeGUCOptions, as suggested by Tom [2]. This is to ensure that
> the GUC C variable initial values are sensible and/or have not gone
> stale compared with the compiled-in defaults of guc_tables.c. This
> patch also changes some GUC C variable initial values which were
> already found (by this sanity-checker) to be different.
I like it.
However it's fails on windows:
https://cirrus-ci.com/task/5545965036765184
running bootstrap script ... FATAL: GUC (PGC_BOOL) update_process_title, boot_val=0, C-var=1
Maybe you need to exclude dynamically set gucs ?
See also this other thread, where I added a flag identifying exactly
that. https://commitfest.postgresql.org/40/3736/
I need to polish that patch some, but maybe it'll be useful for you, too.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-10-20 04:54:47 | Re: Understanding, testing and improving our Windows filesystem code |
| Previous Message | Dilip Kumar | 2022-10-20 03:18:46 | Re: Perform streaming logical transactions by background workers and parallel apply |