| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve errhint for ALTER SUBSCRIPTION ADD/DROP PUBLICATION |
| Date: | 2022-10-18 09:50:26 |
| Message-ID: | 20221018095026.iqdkzojqxxej34rl@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Oct-18, Japin Li wrote:
>
> On Tue, 18 Oct 2022 at 12:00, houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> > Agreed. Here is new version patch which changed the error code and
> > moved the whole command out of the message according to Álvaro's comment.
>
> My bad! The patch looks good to me.
Thank you, I pushed it to both branches, because I realized we were
saying "SET PUBLICATION" when we meant "ADD/DROP"; that hint could be
quite damaging if anybody decides to actually follow it ISTM.
I noted that no test needed to be changed because of this, which is
perhaps somewhat concerning.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-10-18 09:53:17 | Re: remove no longer necessary Perl compatibility hack |
| Previous Message | Melih Mutlu | 2022-10-18 09:49:02 | Re: Mingw task for Cirrus CI |