| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: shadow variables - pg15 edition |
| Date: | 2022-10-10 16:45:49 |
| Message-ID: | 20221010164549.7e5v6vvmcdtxuvov@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-10-10 09:37:38 -0700, Andres Freund wrote:
> On 2022-10-10 18:33:11 +0200, Alvaro Herrera wrote:
> > On 2022-Oct-10, Andres Freund wrote:
> >
> > > Given the age of affected perl instances I suspect there'll not be a lot of
> > > developers affected, and the number of warnings is reasonably small too. It'd
> > > likely hurt more developers to not see the warnings locally, given that such
> > > shadowing often causes bugs.
> >
> > Maybe we can install a filter-out in src/pl/plperl's Makefile for the
> > time being.
>
> We could, but is it really a useful thing for something fixed 6 years ago?
As an out, a hypothetical dev could add -Wno-shadow=compatible-local to their
CFLAGS.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-10-10 16:53:58 | Re: shadow variables - pg15 edition |
| Previous Message | Imseih (AWS), Sami | 2022-10-10 16:40:33 | Re: Add index scan progress to pg_stat_progress_vacuum |