| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: use has_privs_of_role() for pg_hba.conf |
| Date: | 2022-10-06 17:43:43 |
| Message-ID: | 20221006174343.GA444656@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 06, 2022 at 07:33:46AM -0400, Joe Conway wrote:
> On 10/6/22 04:09, Michael Paquier wrote:
>> This patch looks simple, but it is a very sensitive area so I think
>> that we should be really careful. pg_hba.conf does not have a lot of
>> test coverage, so I'd really prefer if we add something to see the
>> difference of behavior and check the behavior that we are switching
>> here.
>
> Agreed
Here is a new version of the patch with a test.
>> Joe, you are registered as a reviewer and committer of this patch, by
>> the way. Are you planning to look at it?
>
> I am meaning to get to it, but as you say wanted to spend some time to
> understand the nuances and life keeps getting in the way. I will try to
> prioritize it over the next week.
Thanks!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Use-has_privs_of_role-for-samerole-samegroup-and-.patch | text/x-diff | 11.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vasya | 2022-10-06 18:04:44 | [PATCH] Check system cache invalidations before each command in transaction |
| Previous Message | Alvaro Herrera | 2022-10-06 17:43:30 | Re: list of acknowledgments for PG15 |