Re: Record SET session in VariableSetStmt

Hi,

On Thu, Oct 06, 2022 at 12:57:17PM +0200, Drouvot, Bertrand wrote:
> Hi hackers,
>
> "SET local" is currently recorded in VariableSetStmt (with the boolean
> is_local) but "SET session" is not.
>
> Please find attached a patch proposal to also record "SET session" so that
> VariableSetStmt records all the cases.
>
> Remark: Recording "SET session" will also help for the Jumbling work being
> done in [1].

I don't think it's necessary. SET and SET SESSION are semantically the same so
nothing should rely on how exactly someone spelled it. This is also the case
for our core jumbling code, where we guarantee (or at least try to) that two
semantically identical statements will get the same queryid, and therefore
don't distinguish eg. LIKE vs ~~.