| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: installcheck-world concurrency issues |
| Date: | 2022-10-05 17:20:27 |
| Message-ID: | 20221005172027.bbcqtbfrwx6wktyw@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-10-05 08:16:37 +0200, Peter Eisentraut wrote:
> On 04.10.22 01:41, Andres Freund wrote:
> > BTW, shouldn't src/test/modules/unsafe_tests use the PG_TEST_EXTRA mechanism
> > somehow? Seems not great to run it as part of installcheck-world, if we don't
> > want to run it as part of installcheck.
>
> I think there are different levels and kinds of unsafeness. The ssl and
> kerberos tests start open server processes on your machine. The
> modules/unsafe_tests just make a mess of your postgres instance. The latter
> isn't a problem when run against a temp instance.
I agree - but I suspect our definition of danger is reversed. For me breaking
an existing cluster is a lot more likely to incur "real world" danger than
starting a throway instance listening to tcp on localhost...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-10-05 17:55:58 | Re: archive modules |
| Previous Message | Andres Freund | 2022-10-05 17:14:45 | Re: [RFC] building postgres with meson - v13 |