Re: [RFC] building postgres with meson - v13

Hi,

On 2022-10-02 12:25:20 -0500, Justin Pryzby wrote:
> On Mon, Sep 26, 2022 at 06:19:51PM -0700, Andres Freund wrote:
> > From 680ff3f7b4da1dbf21d0c7cd87af9bb5ee8b230c Mon Sep 17 00:00:00 2001
> > From: Andres Freund <andres(at)anarazel(dot)de>
> > Date: Wed, 21 Sep 2022 20:36:36 -0700
> > Subject: [PATCH v17 01/23] meson: ci: wip: move compilerwarnings task to meson
>
> This patch isn't finished, but this part looks like a rebase conflict:
>
> - make -s -j${BUILD_JOBS} clean
> + make -s -j${BUILD_JOBS} world-bin

I don't think so - it's the first task building with autoconf / in-tree. I
however shouldn't added ccache to CC, that was an accident. I think I'll
convert it to a vpath build, seems cleaner.

> Also, you wrote "rm -fr build" between building for gcc and clang, but
> since they run in an "always" block, it'd be better to use separate
> dirs, to allow seeing logs for the the all (failed) tasks, in case the
> last one succeeds.

Hm, when are logs important for CompilerWarnings? I don't think we even
collect any? Using a different builddir for the "sibling" tests (i.e. the two
gcc and the two clang tests) would increase the times a bit because we'd
regenerate the bison files etc.

I guess it'll look a bit cleaner to use a build-gcc and a build-clang, just to
get rid of the irregularity of needing that rm -rf.

> On Mon, Sep 26, 2022 at 06:19:51PM -0700, Andres Freund wrote:
> > From 6025cb80d65fd7a8414241931df9f003a292052f Mon Sep 17 00:00:00 2001
> > From: Andres Freund <andres(at)anarazel(dot)de>
> > Date: Sun, 25 Sep 2022 12:07:29 -0700
> > Subject: [PATCH v17 16/23] windows: adjust FD_SETSIZE via commandline
> > define
>
> > +++ b/src/bin/pgbench/meson.build
> > @@ -27,6 +27,8 @@ pgbench = executable('pgbench',
> > pgbench_sources,
> > dependencies: [frontend_code, libpq, thread_dep],
> > include_directories: include_directories('.'),
> > + c_pch: pch_postgres_fe_h,
> > + c_args: host_system == 'windows' ? ['-DFD_SETSIZE=1024'] : [],
> > kwargs: default_bin_args,
> > )
>
> This puts PCH into the preparatory commit.
> Also, src/tools/msvc/Mkvcbuild.pm seems to use spaces rather than tabs.

Oops, will fix.

Greetings,

Andres Freund