From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Robert Haas <rhaas(at)postgresql(dot)org> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits. |
Date: | 2022-09-27 18:51:21 |
Message-ID: | 20220927185121.GE6256@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
This seems to be breaking cfbot:
https://cirrus-ci.com/github/postgresql-cfbot/postgresql
For example:
https://cirrus-ci.com/task/6720256776339456
Some other minor issues:
thais is only used during
=> this
+ elog(ERROR, "unexpected relnumber " UINT64_FORMAT "that is bigger than nextRelFileNumber " UINT64_FORMAT,
=> there should be a space before "that".
+ "tli %u; prev tli %u; fpw %s; xid %u:%u; relfilenumber " UINT64_FORMAT ";oid %u; "
=> and a space before "oid"
+ * Parse relfilenumber value for an option. If the parsing is successful,
+ * returns; if parsing fails, returns false.
returns *true;
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-09-27 19:12:56 | Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits. |
Previous Message | Robert Haas | 2022-09-27 17:42:21 | pgsql: Include common/relpath.h in utils/relfilenumbermap.h |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-09-27 18:55:18 | longfin and tamandua aren't too happy but I'm not sure why |
Previous Message | Melanie Plageman | 2022-09-27 18:20:44 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |