Re: tweak to a few index tests to hits ambuildempty() routine.

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: a(dot)kozhemyakin(at)postgrespro(dot)ru, Noah Misch <noah(at)leadboat(dot)com>, Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, thomas(dot)munro(at)gmail(dot)com
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
Date: 2022-09-25 15:57:07
Message-ID: 20220925155707.2uc35oe3h4ckd4j5@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Sep-25, Tom Lane wrote:

> That's what it's saying *now*, but after rereading this whole thread
> I see that it apparently said something different last week. So the
> coverage is probabilistic, which squares with this discussion and
> with some tests I just did locally. That's not good.

Completely agreed.

> I propose that we revert 4fb5c794e and instead add separate test
> cases that just create unlogged indexes (I guess they don't actually
> need to *do* anything with them?).

WFM. I can do it next week, or feel free to do so if you want.

> Looks like dec8ad367 could be reverted as well, in view of 2f2e24d90.

Yeah, sounds good.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-09-25 16:19:54 Re: tweak to a few index tests to hits ambuildempty() routine.
Previous Message Wolfgang Walther 2022-09-25 15:55:05 Add ON CONFLICT DO RETURN clause