| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Benoit Lobréau <benoit(dot)lobreau(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: archive modules |
| Date: | 2022-09-23 16:14:02 |
| Message-ID: | 20220923161402.GA736566@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 23, 2022 at 05:58:42AM -0400, Peter Eisentraut wrote:
> On 15.09.22 00:27, Nathan Bossart wrote:
>> Both archive_command and archive_library are PGC_SIGHUP, so IIUC that
>> wouldn't be sufficient. I attached a quick sketch that seems to provide
>> the desired behavior. It's nowhere near committable yet, but it
>> demonstrates what I'm thinking.
>
> What is the effect of issuing a warning like in this patch? Would it just
> not archive anything until the configuration is fixed? I'm not sure what
> behavior you are going for; it's a bit hard to imagine from just reading the
> patch.
Yes, it will halt archiving and emit a WARNING, just like what happens on
released versions when you leave archive_command empty.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2022-09-23 16:37:34 | Re: First draft of the PG 15 release notes |
| Previous Message | Tom Lane | 2022-09-23 15:25:44 | Re: First draft of the PG 15 release notes |