| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Extending outfuncs support to utility statements |
| Date: | 2022-09-22 17:01:03 |
| Message-ID: | 20220922170103.6tnwbpzeddceiyyl@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-09-22 12:48:47 -0400, Tom Lane wrote:
> I wrote:
> > I think this is the issue Peter mentioned about needing to distinguish
> > between empty strings and NULL strings. We're going to need to rethink
> > the behavior of pg_strtok() a bit to fix that.
>
> After staring at the code a bit, I think we don't need to touch
> pg_strtok() per se. I propose that this can be resolved with changes
> at the next higher level. Let's make outToken print NULL as <> as
> it always has, but print an empty string as "" (two double quotes).
> If the raw input string is two double quotes, print it as \"" to
> disambiguate. This'd require a catversion bump when committed,
> but I don't think there are any showstopper problems otherwise.
Makes sense to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-09-22 17:03:05 | Re: Mingw task for Cirrus CI |
| Previous Message | Ashutosh Sharma | 2022-09-22 16:54:49 | Re: binary version of pg_current_wal_insert_lsn and pg_walfile_name functions |