| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Prefetch data referenced by the WAL, take II. |
| Date: | 2022-09-13 10:07:40 |
| Message-ID: | 20220913100740.cgt3cddnrjt3syuu@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2022-Sep-13, Thomas Munro wrote:
> I'd go for your second suggestion. 'therein' doesn't convey much (we
> already said 'in the WAL', and therein is just a slightly formal and
> somehow more Germanic way of saying 'in it' which is kinda
> duplicative; maybe 'by it' is what we want but that's still kinda
> implied already), whereas adding 'data' makes it slightly clearer that
> it's blocks from relations and not, say, the WAL itself.
>
> Also, hmm, it's not really the 'Maximum buffer size', it's the 'Buffer size'.
Sounds reasonable. Pushed these changes. Thank you!
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-09-13 12:11:38 | Re: pgsql: Doc: Explain about Column List feature. |
| Previous Message | Alvaro Herrera | 2022-09-13 10:06:12 | pgsql: Improve wal_decode_buffer_size description some more |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-09-13 10:25:51 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Laurenz Albe | 2022-09-13 10:04:04 | Re: Tuples inserted and deleted by the same transaction |