Re: [PATCH v1] fix potential memory leak in untransformRelOptions

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH v1] fix potential memory leak in untransformRelOptions
Date: 2022-09-13 10:01:47
Message-ID: 20220913100147.zm322p3c2qquru7c@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Sep-09, Alvaro Herrera wrote:

> Keeping 's' and removing the pstrdups better uses memory, because we
> have a single palloc'ed chunk per option rather than two.

Pushed. This is pretty much cosmetic, so no backpatch.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"The Gord often wonders why people threaten never to come back after they've
been told never to return" (www.actsofgord.com)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2022-09-13 10:04:04 Re: Tuples inserted and deleted by the same transaction
Previous Message Kyotaro Horiguchi 2022-09-13 09:48:45 Re: START_REPLICATION SLOT causing a crash in an assert build