| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: introduce bufmgr hooks |
| Date: | 2022-09-01 20:11:50 |
| Message-ID: | 20220901201150.GA784954@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 31, 2022 at 08:29:31AM -0700, Andres Freund wrote:
> I'm very doubtful this is a good idea. These are quite hot paths. While not a
> huge cost, adding an indirection isn't free nonetheless.
Are you concerned about the NULL check or the potential hook
implementations? I can probably test the former pretty easily, but the
latter seems like a generic problem for many hooks.
> I also think it'll
> make it harder to improve things in this area, which needs quite a bit of
> work.
If you have specific refactoring in mind that you think ought to be a
prerequisite for this change, I'm happy to give it a try.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-09-01 20:33:18 | Re: Bug: When user-defined AM is used, the index path cannot be selected correctly |
| Previous Message | Tom Lane | 2022-09-01 19:35:52 | Re: Bug: Reading from single byte character column type may cause out of bounds memory reads. |