| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, samay sharma <smilingsamay(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: [RFC] building postgres with meson - v11 |
| Date: | 2022-08-24 17:42:48 |
| Message-ID: | 20220824174248.kuzb7txdnkgytvid@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-08-17 14:53:17 -0700, Andres Freund wrote:
> > - In the top-level meson.build, the "renaming" of the Windows system
> > name
> >
> > host_system = host_machine.system() == 'windows' ? 'win32' :
> > host_machine.system()
> > build_system = build_machine.system() == 'windows' ? 'win32' :
> > build_machine.system()
> >
> > seems unnecessary to me. Why not stick with the provided names?
>
> Because right now we also use it for things like choosing the "source" for
> pg_config_os.h (i.e. include/port/{darwin,linux,win32,..}.h). And it seemed
> easier to just have one variable name for all of it.
I am now changing this so that there's an additional 'portname' variable for
this purpose. Otherwise the meson names are used.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-08-24 18:01:11 | Re: use ARM intrinsics in pg_lfind32() where available |
| Previous Message | Tom Lane | 2022-08-24 17:30:15 | Re: Stack overflow issue |