Re: Should 'sum(mvf)' read 'sum(mcv)'...?

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: eric(dot)mutta(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Should 'sum(mvf)' read 'sum(mcv)'...?
Date: 2022-08-22 10:08:36
Message-ID: 20220822100836.g3y4ckauuebfnach@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

Hi,

On Mon, Aug 22, 2022 at 11:13:38AM +0200, Daniel Gustafsson wrote:
> > On 22 Aug 2022, at 09:48, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> > On Sun, Aug 21, 2022 at 11:02:04PM +0000, PG Doc comments form wrote:
>
> >> It appears the above sentence is referring to the "(1 - sum(mvf))" portion
> >> of the formula, however I am not sure what "mvf" is referring to
> >> there...shouldn't it be "(1 - sum(mcv))" in order to match what the
> >> explanatory sentence is saying?
> >
> > It should be mcf, ie. Most Common Frequencies. It looks like a very old typo
> > that survived until now.
>
> That seems plausible, but it does seem introduced on purpose in f5678e8e075 so
> CC:ing Tom for a trip down memory lane.

That was actually introduced 2 years before in 234d50812c8 by Bruce.

> Looking at this I noticed that we mark up MCV and MCF as acronyms but they
> aren't defined in acronyms.sgml. ISTM it's a good idea to keep a 1:1 mapping
> between markup and content, so we should probably do that as per the attached?

Agreed, although MCF is only used in planstats.sgml and the acronym defined
locally.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Daniel Gustafsson 2022-08-22 10:26:42 Re: Should 'sum(mvf)' read 'sum(mcv)'...?
Previous Message Daniel Gustafsson 2022-08-22 09:13:38 Re: Should 'sum(mvf)' read 'sum(mcv)'...?