From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: something has gone wrong, but what is it? |
Date: | 2022-08-10 14:56:06 |
Message-ID: | 20220810145606.ezf6wi5olhwplub7@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2022-08-10 10:49:59 -0400, Robert Haas wrote:
> On Wed, Aug 10, 2022 at 9:53 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >
> > - elog(ERROR, "something has gone wrong");
> > + elog(ERROR, "unrecognized AuxProcType: %d", (int) auxtype);
> >
> > +1 ... the existing message is clearly not up to project standard.
>
> After a bit of further looking around I noticed that there's another
> check for an invalid auxtype in this function which uses a slightly
> different message text and also PANIC rather than ERROR.
>
> I think we should adopt that here too, for consistency, as in the attached.
>
> The distinction between PANIC and ERROR doesn't really seem to matter
> here. Either way, the server goes into an infinite crash-and-restart
> loop. May as well be consistent.
Makes sense.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-08-10 15:00:20 | Re: Generalize ereport_startup_progress infrastructure |
Previous Message | Tom Lane | 2022-08-10 14:51:00 | SPI versus read/write expanded datums |