From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: moving basebackup code to its own directory |
Date: | 2022-08-10 14:25:03 |
Message-ID: | 20220810142503.GG19644@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 10, 2022 at 10:08:02AM -0400, Robert Haas wrote:
> On Tue, Aug 9, 2022 at 3:28 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Tue, Aug 9, 2022 at 2:40 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > > It looks like this updates the header comments in the .h files but not the .c
> > > files.
> > >
> > > Personally, I find these to be silly boilerplate ..
> >
> > Here is a version with some updates to the silly boilerplate.
>
> If there are no further comments on this I will go ahead and commit it.
>
> David Steele voted for back-patching this on the grounds that it would
> make future back-patching easier, which is an argument that seems to
> me to have some merit, although on the other hand, we are already into
> August so it's quite late in the day. Anyone else want to vote?
No objection to backpatching to v15, but if you don't, git ought to handle
renamed files just fine.
These look like similar precedent for "late" renaming+backpatching: 41dae3553,
47ca48364
--
Justin
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-08-10 14:49:59 | Re: something has gone wrong, but what is it? |
Previous Message | Robert Haas | 2022-08-10 14:08:02 | Re: moving basebackup code to its own directory |