| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Rely on __func__ being supported |
| Date: | 2022-08-10 14:03:34 |
| Message-ID: | 20220810140334.itf5rw4mvfmojnuu@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hello
On 2022-Aug-07, Andres Freund wrote:
> On 2022-08-07 19:40:14 +0200, Alvaro Herrera wrote:
> > I'd rather we keep PG_FUNCNAME_MACRO defined to __func__ ... it costs us
> > nothing. Would anybody oppose that?
>
> I'm fine with re-adding the macro, as long as we don't re-add in-tree users.
After further thinking, I conclude there's no need for this. It's quite
easy to add a "#ifndef PG_FUNCNAME_MACRO" stanza in third-party code if
needed, and just rely on __func__ otherwise.
Thanks
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-10 17:37:47 | pgsql: Fix handling of R/W expanded datums that are passed to SQL funct |
| Previous Message | Daniel Gustafsson | 2022-08-10 12:17:13 | pgsql: Fix typo in test_oat_hooks README |