| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Rely on __func__ being supported |
| Date: | 2022-08-07 17:40:14 |
| Message-ID: | 20220807174014.xuz7i47oi3ovgwgd@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2022-Aug-07, Andres Freund wrote:
> Rely on __func__ being supported
>
> Previously we fell back to __FUNCTION__ and then NULL. As __func__ is in C99
> that shouldn't be necessary anymore.
>
> Solution.pm defined HAVE_FUNCNAME__FUNCTION instead of
> HAVE_FUNCNAME__FUNC (originating in 4164e6636e2), as at some point in the past
> MSVC only supported __FUNCTION__. Our minimum version supports __func__.
I'd rather we keep PG_FUNCNAME_MACRO defined to __func__ ... it costs us
nothing. Would anybody oppose that?
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| backw.patch | text/x-diff | 412 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-08-07 17:45:25 | Re: pgsql: Rely on __func__ being supported |
| Previous Message | Andres Freund | 2022-08-07 16:36:40 | pgsql: aix: Remove checks for very old OS versions |