Re: failing to build preproc.c on solaris with sun studio

Hi,

On 2022-08-07 01:17:22 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2022-08-06 22:55:14 -0400, Tom Lane wrote:
> >> IMO, it'd be entirely reasonable for Andres to say that *he* doesn't
> >> want to fix the meson build scripts for niche platform X. Then
> >> it'd be up to people who care about platform X to make that happen.
> >> Given the current plan of supporting the Makefiles for some years
> >> more, there wouldn't even be any great urgency in that.
>
> > The "problem" in this case is that maintaining pgxs compatibility, as we'd
> > discussed at pgcon, requires emitting stuff for all the @whatever@ things in
> > Makefile.global.in, including with_gnu_ld.
>
> Sure, but why can't you just leave that for later by hard-wiring it
> to false in the meson build? As long as you don't break the Makefile
> build, no one is worse off.

Yea, that's what I am doing now. But it's a fair bit of work figuring out
which values need at least approximately correct values and which not.

It'd be nice if we had an automated way of building a lot of the extensions
out there...

> I think if we want to get this past the finish line, we need to
> acknowledge that the initial commit isn't going to be perfect.
> The whole point of continuing to maintain the Makefiles is to
> give us breathing room to fix remaining issues in a leisurely
> fashion.

Wholeheartedly agreed.

Greetings,

Andres Freund